Improve type hinting for HTTPError.request#886
Merged
florimondmanca merged 1 commit intomasterfrom Mar 29, 2020
Merged
Conversation
florimondmanca
added
the
user-experience
florimondmanca
force-pushed
the
exc-request
branch
from
9b3a33f to
868c04d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small quality-of-life improvement to our typing coverage: make sure that type checkers are aware that
HTTPError.requestalways refers to a well-definedRequestinstance.With the current state of things, assuming the issue described in #885 was fixed (it is addressed here too), mypy wouldn't let users access the
requestwithout casting it to a non-Nonefirst, which is bad UX.There's also a hidden assumption that
exc.requestalways has a request set, but it's not enforced anywhere in the code.This PR updates
HTTPErrorand the population of the request to reflect these points.